[RFT 1/5] realtek: split DGS-1210-10P DTS

[Adrian Schmutzler]

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Paul Fertser
> Sent: Dienstag, 5. Oktober 2021 21:40
> To: openwrt-devel at lists.openwrt.org
> Cc: Paul Fertser <fercerpav at gmail.com>
> Subject: [RFT 1/5] realtek: split DGS-1210-10P DTS
> 
> In preparations to add support for more similar boards the common part is
> split into a DTSI.
> 
> The model that's currently supported is known to be revision F1 so mark it
> accordingly and provide appropriate compatible string for sysupgrade to
> work.
> 

[...]

> diff --git a/target/linux/realtek/image/Makefile
> b/target/linux/realtek/image/Makefile
> index 5e4b4cde800d..c1e47f719f3a 100644
> --- a/target/linux/realtek/image/Makefile
> +++ b/target/linux/realtek/image/Makefile
> @@ -53,12 +53,15 @@ define Device/d-link_dgs-1210
>    DEVICE_VENDOR := D-Link
>  endef
> 
> -define Device/d-link_dgs-1210-10p
> +define Device/d-link_dgs-1210-10p-f1
>    $(Device/d-link_dgs-1210)
> +  SOC := rtl8380

Please, don't overwrite SOC on different levels. If these devices have different SOC, it should be moved out of the common recipe and been set for every device individually.

Best

Adrian

>    DEVICE_MODEL := DGS-1210-10P
> +  DEVICE_VARIANT := F1
> +  SUPPORTED_DEVICES += d-link,dgs-1210-10p
>    DEVICE_PACKAGES += lua-rs232
>  endef
> -TARGET_DEVICES += d-link_dgs-1210-10p
> +TARGET_DEVICES += d-link_dgs-1210-10p-f1
> 
>  define Device/d-link_dgs-1210-16
>    $(Device/d-link_dgs-1210)
> --
> 2.17.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20211009/7051b19b/attachment.sig>