[PATCH 3/3] ath79: add support for MikroTik RouterBOARD 912UAG-2HPnD

[Sergey Ryazanov]

On Mon, Jun 14, 2021 at 9:02 PM Adrian Schmutzler
<mail at adrianschmutzler.de> wrote:
>
> Hi,
>
> a few remaining comments below.
>
>> +     gpio-export {
>> +             compatible = "gpio-export";
>> +
>> +             usb_power {
>> +                     label = "power:usb";
>
> gpio-export nodes normally don't have a label property. We have gpio-export,name instead.
>
>> +                     gpio-export,name = "power-usb";
>> +                     gpio-export,output = <1>;
>> +                     gpios = <&ssr 6 GPIO_ACTIVE_HIGH>;
>> +             };
>> +
>> +             pcie_power {
>> +                     label = "power:pcie";
>> +                     gpio-export,name = "power-pcie";
>> +                     gpio-export,output = <0>;
>> +                     gpios = <&ssr 7 GPIO_ACTIVE_HIGH>;
>> +             };
>> +     };
>> +};
>> +
>> +&spi {
>> +     status = "okay";
>> +
>> +     compatible = "qca,ar7100-spi";
>> +
>> +     cs-gpios = <0>, <&gpio_latch 0 GPIO_ACTIVE_LOW>;
>
> I still don't think this belongs here. Why would it be the only device requiring this, while we removed it everywhere else?

Every other board uses SPI controller CS lines, so they are not needed
in this property. While the RB912 board uses the controller CS line
only to control the first device on the bus, and the regular GPIO line
to control the second device. So yes, this board requires the cs-gpios
property.

This board is overly special, the latch based GPIO controller will
just suffice to mention.

>> +
>> +     flash at 0 {
>> +             compatible = "jedec,spi-nor";
>> +             reg = <0>;
>> +             spi-max-frequency = <80000000>;
>
> Typically, speeds > 50 MHz require m25p,fast-read?

-- 
Sergey