[PATCH 3/3] ath79: add support for MikroTik RouterBOARD 912UAG-2HPnD

[Adrian Schmutzler]

Hi,

a few remaining comments below.

> +	gpio-export {
> +		compatible = "gpio-export";
> +
> +		usb_power {
> +			label = "power:usb";

gpio-export nodes normally don't have a label property. We have gpio-export,name instead.

> +			gpio-export,name = "power-usb";
> +			gpio-export,output = <1>;
> +			gpios = <&ssr 6 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		pcie_power {
> +			label = "power:pcie";
> +			gpio-export,name = "power-pcie";
> +			gpio-export,output = <0>;
> +			gpios = <&ssr 7 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +};
> +
> +&spi {
> +	status = "okay";
> +
> +	compatible = "qca,ar7100-spi";
> +
> +	cs-gpios = <0>, <&gpio_latch 0 GPIO_ACTIVE_LOW>;

I still don't think this belongs here. Why would it be the only device requiring this, while we removed it everywhere else?

> +
> +	flash at 0 {
> +		compatible = "jedec,spi-nor";
> +		reg = <0>;
> +		spi-max-frequency = <80000000>;

Typically, speeds > 50 MHz require m25p,fast-read?

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210614/3c4a44b5/attachment.sig>