[OpenWrt-Devel] [PATCH v2] ath79: add support for Netgear WNDR4300

[Michal Cieslakiewicz]

Hello Adrian,

Thanks for your feedback!

> Hi,
> 
> Same question I asked on zyxel support: Do you expect several further
> netgear devices to be added to nand target?
> 
> Up to let's say three/four devices, I'd prefer to merge stuff into
> nand.mk, otherwise I'd say a separate file is justified, so we do get
> a .mk file for every vendor.
> 

Yes, I'm planning to take on WNDR4300v2 (which, as usual, is quite
different from v1 but still QCA-based -> ath79) after this one gets to
mainline. I didn't investigated that router yet (it looks like a SPI
NAND device) but I expect it to require the same image tools.
Anyway, it is your call, I just didn't wanted to put Netgear-specific
stuff into main nand Makefile.

> 
> I there a real need to deviate from the sysupgrade.bin/factory.img
> naming scheme here? I didn't find that naming scheme anywhere else in
> ath79 or ramips.
> 

ar71xx replaces 'squashfs' with 'ubi' in factory image name, for ath79 I
couldn't find matching rename function in mk files, so I decided to
append 'ubi' in that very simple way. Again, I do not want to create
mess, I just wanted to preserve information that ar71xx provides.

> 
> I hesitated when reviewing the DTS section of your patch, but since
> this can be merged with zyxel here, I'd recommend to change the
> partition label to "art", which is frequently used for that very
> reason.
> 

It is for compatibility with vendor naming 'scheme' (which I agree is
inconsistent by itself), there is also 'caldata_backup' partition that
is a copy of 'caldata'.

Cheers
Michal

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel