[OpenWrt-Devel] [PATCH v2] ath79: add support for Netgear WNDR4300

[Adrian Schmutzler]

Hi,

> diff --git a/target/linux/ath79/image/Makefile b/target/linux/ath79/image/Makefile
> index 24768ef5e0..b6ac83cdc1 100644
> --- a/target/linux/ath79/image/Makefile
> +++ b/target/linux/ath79/image/Makefile
> @@ -77,6 +77,7 @@ include ./generic-ubnt.mk
>  endif
>  ifeq ($(SUBTARGET),nand)
>  include ./nand.mk
> +include ./nand-netgear.mk

Same question I asked on zyxel support: Do you expect several further netgear devices to be added to nand target?

Up to let's say three/four devices, I'd prefer to merge stuff into nand.mk, otherwise I'd say a separate file is justified, so we do get a .mk file for every vendor.

> diff --git a/target/linux/ath79/image/nand-netgear.mk b/target/linux/ath79/image/nand-netgear.mk
> new file mode 100644
> index 0000000000..b25e6ec66c
> --- /dev/null
> +++ b/target/linux/ath79/image/nand-netgear.mk
> @@ -0,0 +1,34 @@
> +include ./common-netgear.mk	# for netgear-uImage
> +
> +# (pad-offset 129 = 2 * uimage_header + 0xff)
> +define Device/netgear_ath79_nand
> +  DEVICE_VENDOR := NETGEAR
> +  DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport
> +  KERNEL_SIZE := 2048k
> +  BLOCKSIZE := 128k
> +  PAGESIZE := 2048
> +  IMAGE_SIZE := 25600k
> +  KERNEL := kernel-bin | append-dtb | lzma -d20 | \
> +	pad-offset $$(KERNEL_SIZE) 129 | \
> +	netgear-uImage lzma | append-string -e '\xff' | \
> +	append-uImage-fakehdr filesystem $$(NETGEAR_KERNEL_MAGIC)
> +  KERNEL_INITRAMFS := kernel-bin | append-dtb | lzma -d20 | \
> +	netgear-uImage lzma
> +  IMAGES := ubi-sysupgrade.bin ubi-factory.img
> +  IMAGE/ubi-factory.img := append-kernel | append-ubi | netgear-dni | \
> +	check-size $$$$(IMAGE_SIZE)
> +  IMAGE/ubi-sysupgrade.bin := sysupgrade-tar | append-metadata | \
> +	check-size $$$$(IMAGE_SIZE)

I there a real need to deviate from the sysupgrade.bin/factory.img naming scheme here?
I didn't find that naming scheme anywhere else in ath79 or ramips.

> diff --git a/target/linux/ath79/nand/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom b/target/linux/ath79/nand/base-
> files/etc/hotplug.d/firmware/10-ath9k-eeprom
> index 88a40b5d41..ae1d3572a8 100644
> --- a/target/linux/ath79/nand/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom
> +++ b/target/linux/ath79/nand/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom
> @@ -9,6 +9,9 @@ board=$(board_name)
>  case "$FIRMWARE" in
>  "ath9k-eeprom-ahb-18100000.wmac.bin")
>  	case $board in
> +	netgear,wndr4300)
> +		caldata_extract "caldata" 0x1000 0x440
> +		;;

I hesitated when reviewing the DTS section of your patch, but since this can be merged with zyxel here, I'd recommend to change the partition label to "art", which is frequently used for that very reason.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191030/c003a26b/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel