[OpenWrt-Devel] [PATCH v2] ath79: fix several issues for ZyXEL NBG6716

[Adrian Schmutzler]

Hi,

> > +define Build/zyxel-buildkerneljffs
> > +	rm -rf  $(KDIR_TMP)/zyxelnbg6716
> > +	mkdir -p $(KDIR_TMP)/zyxelnbg6716/image/boot
> > +	cp $@ $(KDIR_TMP)/zyxelnbg6716/image/boot/vmlinux.lzma.uImage
> > +	$(STAGING_DIR_HOST)/bin/mkfs.jffs2 \
> > +		--big-endian --squash-uids -v -e 128KiB -q -f -n -x lzma -x rtime \
> > +		-o $@ \
> > +		-d $(KDIR_TMP)/zyxelnbg6716/image
> > +	rm -rf $(KDIR_TMP)/zyxelnbg6716
> >   endef
> >
> >   define Build/zyxel-factory
> > [...]
> 
> "Build/zyxel-buildkerneljffs" looks to be a "generic", however it is
> using a device-specific name for its temp directory.
> 
> At least in my opinion, the directory should either be created as a
> result of a call to mktemp(1), or generically named.

That's neither a simple cosmetic change nor a fix, so IMO it should be a patch of its own.

Feel invited to submit it, but note that I won't review/merge it due to my limited expertise in this field.

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191029/da1e0c08/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel