[OpenWrt-Devel] [PATCH v3] ramips: add support for Xiaomi Mi Wi-Fi Router 3G v2

[Adrian Schmutzler]

Hi,

> > > +	xiaomi,mir3g-v2)
> > > +		wan_mac=$(mtd_get_mac_binary factory 0xe006)
> > > +		;;
> >
> > This can be merged with elecom,wrc-1167ghbk2-s|\ etc.
> 
> I rebased to current master and added label_mac (as per Roger's
> suggestion), and since I can not be sure about all the other devices,
> I left the dedicated section for this model.

Yes, merging only makes sense if cases are exactly the same. With the addition of label_mac (providing additional information), you cannot merge this anymore. (So, you did it correctly in v4).

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191025/03b9c7f7/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel