[OpenWrt-Devel] [PATCH v3] ramips: add support for Xiaomi Mi Wi-Fi Router 3G v2

[Paul Fertser]

Hi Roger,

Thank you for the review!

On Fri, Oct 11, 2019 at 07:14:25PM +0200, Roger Pueyo Centelles | Guifi.net wrote:
>  +       xiaomi,mir3g-v2)
>  +               wan_mac=$(mtd_get_mac_binary factory 0xe006)
>  +               ;;
> 
> You may want to add "label_mac=$wan_mac" there, if the MAC address on the back
> label matches the WAN interface (on the R4G it does).

Indeed, done.

> Also, it looks like a newline should be added at the end of the .dts file.

I've checked and I see there's already a newline present at the end of
the file.

> Since there are two Xiaomi Router 4A variants, the 100m and the Gigabit Edition,
> you may want to use:
> 
> +  DEVICE_ALT0_VENDOR := Xiaomi
> +  DEVICE_ALT0_MODEL := Mi Router 4A
> +  DEVICE_ALT0_VARIANT := Gigabit Edition

Done.

> Last, I added the device to uboot-envtools. Feel free to copy it:
> [2]https://github.com/openwrt/openwrt/pull/2486/commits/2625499ca554449e7a19bb5f6f61acdefb5a69e1

Since the uboot partition is not writeable by default, and there's no
way to install OpenWrt without changing it first by some other means
(such as an external SPI flash programmer) I have a feeling adding it
to uboot-envtools wouldn't be useful.

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav at gmail.com

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel