[OpenWrt-Devel] FW: [PATCH 2/2] ath79: add support for Netgear WNDR3700v4

[Paul Blazejowski]

On 11/13/19 12:42 PM, Schmutzler, Adrian wrote:
>  
> 
>  
> 
> *From:*Adrian Schmutzler [mailto:mail at adrianschmutzler.de]
> *Sent:* Mittwoch, 13. November 2019 18:39
> *To:* 'Paul Blazejowski' <paulb at blazebox.homeip.net>;
> 'openwrt-devel at lists.openwrt.org' <openwrt-devel at lists.openwrt.org>
> *Subject:* RE: [PATCH 2/2] ath79: add support for Netgear WNDR3700v4
> 
>  
Hi Adrian,

> 
> Hi,
> 
>> diff --git a/target/linux/ath79/dts/ar9344_netgear_wndr3700-v4.dts
>> b/target/linux/ath79/dts/ar9344_netgear_wndr3700-v4.dts
>> new file mode 100644
>> index 0000000000..eb1ad731c3
>> --- /dev/null
>> +++ b/target/linux/ath79/dts/ar9344_netgear_wndr3700-v4.dts
>> @@ -0,0 +1,9 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
>> +/dts-v1/;
>> +
>> +#include "ar9344_netgear_wndr.dtsi"
>> +
>> +/ {
>> +    compatible = "netgear,wndr3700-v4", "qca,ar9344";
>> +    model = "Netgear WNDR3700 v4";
>> +};
> 
> Indent should be fixed here (-> tab).

Ok, noted!

> 
> One could also copy the flashing instructions to the commit message, so
> you do not have to search for them.

OK

> 
> Both could also be done by a willing dev during merge, unless there is
> more to fix.

Thanks for your help!

> 
> Best
> 
> Adrian
> 

Cheerios!
-paul

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel