[OpenWrt-Devel] [PATCH v4 0/6] intel-microcode: load as early as possible

[John Crispin]

On 27/11/2018 18:15, Tomasz Maciej Nowak wrote:
> W dniu 27.11.2018 o 18:04, John Crispin pisze:
>> On 27/11/2018 16:11, Tomasz Maciej Nowak wrote:
>>> W dniu 27.11.2018 o 14:47, Lucian Cristian pisze:
>>>> On 26.11.2018 23:58, Tomasz Maciej Nowak wrote:
>>>>> W dniu 26.11.2018 o 22:47, Lucian Cristian pisze:
>>>>>> On 26.11.2018 23:11, Tomasz Maciej Nowak wrote:
>>>>>>> W dniu 26.11.2018 o 21:44, Lucian Cristian pisze:
>>>>>>>> On 20.11.2018 18:20, Tomasz Maciej Nowak wrote:
>>>>>>>>> This small series addresses current problem with late loading of Intel
>>>>>>>>> microcode in OpenWrt. Following the commit messages [1] and later
>>>>>>>>> discussion, late loading off the microcode can be ineffective for some
>>>>>>>>> processors [2] and for others disabled [3]. Also it is discouraged for
>>>>>>>>> any processor starting from Haswell and Silvermont.
>>>>>>>>> Therefore this series converts the Intel microcode bundle to an initial
>>>>>>>>> ram disk which is loaded with grub, so kernel has access to it as early
>>>>>>>>> as possible.
>>>>>>>>> Previous patch series:
>>>>>>>>> https://patchwork.ozlabs.org/project/lede/list/?series=39372
>>>>>>>>>
>>>>>>>>> 1. https://lore.kernel.org/patchwork/cover/348236
>>>>>>>>> 2. https://lore.kernel.org/patchwork/cover/348236/#508603
>>>>>>>>> 3. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=723f2828a98c8ca19842042f418fb30dd8cfc0f7
>>>> [...]
>>>>>>>>> No, Your grub doesn't understand *if* command because it's old an doesn't have "test" module enabled. It's left there because sysupgrade doesn't upgrade grub, it updates only boot and root partitions. If You'll write the created image not by sysupgrade but by dd'ing to boot medium, It'll start properly without interruptions.
>>>>>>>>> BTW thank You for the report.
>>>>>>>>>
>>>>>> error: can't find command '['.
>>>>>> error: can't find command '['.
>>>>>>
>>>>>> Press any key to continue...
>>>>>>
>>>>>>
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>>
>>>> Can I repair this somehow without writing the full image ? only by reversing the commits ?
>>> No, not at the moment. I'm trying to figure out best way to update grub on sysupgrade, until then reverting the mentioned commits will bring back old behavior, and no manual intervention on boot will be necessary.
>>
>> shall we revert the series ?
> Yes, but not the whole series only these commits:
>
> 546fced2a23557e95dd34246744c3aa6cad92fe6 x86: add intel microcode entries to grub config
> 022ffb56b2491fd7d8051ac6e6c7622ecc313d8f intel-microcode: create early load microcode image
> a822283c7e56bb3b409712e0eb9af5a91aac247d x86: add amd microcode entries to grub config
> 975019b3a755ec3b91864b60b45e5ee104075096 amd64-microcode: create early load microcode image
>
> The rest is okay, won't cause any regressions and will save the effort.
>
> Thank You.
>
done ....



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel