[OpenWrt-Devel] [PATCHv2] Allow VLAN filtering if needed.

[Hauke Mehrtens]

On 11/21/18 5:01 PM, Jonathan Thibault wrote:
> On 21/11/18 09:13 AM, Daniel Golle wrote:
>> Hi!
>>
>> On Thu, Nov 15, 2018 at 07:58:07PM +0100, Daniel Golle wrote:
>>> Hi Jonathan,
>>>
>>> On Thu, Nov 15, 2018 at 11:12:54AM -0500, Jonathan Thibault wrote:
>>>> Greetings,
>>>>
>>>> I would like to propose enabling CONFIG_BRIDGE_VLAN_FILTERING on
>>>> OpenWRT
>>>> releases.
>>> I've suggested that already about a year ago. Now that a significant
>>> amount of targets uses DSA this is even more needed and I think we
>>> should enable it now before the 2019 release is coming up.
>> I'm about to merge this into master with my SoB added as you didn't
>> sign off the patch (which is so trivial that in practise this doesn't
>> matter). Find it in my staging tree [1] and raise your voice in case
>> of any concerns. Otherwise I'll merge it by the end of the week.
> That's perfectly fine.  I'm just happy it's getting merged, OpenWRT just
> got more useful.

I posted a similar patch some time ago and then we agreed to not merge
it, because it increases the kernel size by 4 KBytes compressed:
https://lists.openwrt.org/pipermail/openwrt-devel/2018-April/011715.html

I also would like to have this feature and though about to make this
depend on some sort of feature flag.

As OpenWrt supports very different devices by now, some of them having
just 8MB flash / 32 MB RAM and others having a lot more memory, it would
be good to have some sort for feature flag for the size and activate
such settings based on that.

I have no problem when you merge this patch as is.

Hauke

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20181121/abfd90ea/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel