[OpenWrt-Devel] [PATCH] ipq806x: add ath10k calibration data MAC addresses patching

[Ben Greear]

On 11/14/2018 11:53 AM, Felix Fietkau wrote:
> On 2018-11-14 20:39, Ben Greear wrote:
>> On 11/01/2018 03:18 AM, Felix Fietkau wrote:
>>> On 2018-10-28 17:39, Christian Lamparter wrote:
>>>> Ben Greear reported in his patch:
>>>> |Subject: netgear r7800: Fix mac address of radios.
>>>> |
>>>> |Reloading the driver causes the phyX to change, and that
>>>> |caused the MAC address to change.
>>>>
>>>> This is because all ODM/OEMs except QCA bothered to write
>>>> the correct MAC address for the ath10k wifi into the
>>>> calibration data.
>>> I don't think that's a strong enough reason to further propagate the
>>> messy calibration data patching.
>>> How about checking the sysfs device path in the hotplug script instead
>>> to make sure we're changing the MAC for the right wifi device?
>>
>> Would this mean that the NIC is loaded with one (potentially bogus)
>> MAC, and then hotplug would very soon after set the proper MAC?
>>
>> If so, that is liable to mess up stock ath10k firmware since it will not
>> properly calculate its rx-bssid mask.
> To improve MAC address handling, we should probably call
> pdev_set_base_macaddr_cmdid before bringing up the first vif and use the
> first vif MAC address there.

That might help in general, though not sure exactly how well that is implemented
in stock QCA firmware..  My ath10k-ct doesn't need that to do proper bssid-mask,
and I'd still like the 'phy' to have the correct MAC address, so I still think MAC
should be proper from the very first if at all possible.

I tried an earlier version of Christian's patch and it works well for me on the r7800.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel