[OpenWrt-Devel] [PATCH v2] ramips: EX2700: remove unused kernel modules

[Joseph C. Lehner]

On 2016-03-10 18:50, John Crispin wrote:
> 
> 
> On 10/03/2016 17:57, Joseph C. Lehner wrote:
>> Just a quick followup, this applies to other devices as well: the
>> profile for the Ubiquity EdgeRouter X (mt7621, ubnt-erx) for example uses
>>
>> PACKAGES:=-kmod-mt76 -wpad-mini -kmod-cfg80211
>>
>> but all these packages are in fact included in the snapshot images created
>> by the OpenWrt buildbot.
>>
>> Joseph
>>
> 
> because the snapshot builder build generic profiles. this is expected
> behavior. you need to either select the profile or sue the image
> builder. snapshot do neither of the 2
> 
> 	John
>

Oh okay, I was not aware of that; thanks!

Joseph


>> On 2016-03-10 17:22, Joseph C. Lehner wrote:
>>> Okay thanks, I'll keep that in mind. But the second issue still remains:
>>>
>>> I was referring to the latest snapshot build for the ex2700 from
>>> downloads.openwrt.org, which come with all kmod-usb* stuff included,
>>> even though these modules should have been removed by the PACKAGES
>>> specification even before this patch, and I'm assuming that the same
>>> thing will happen to kmod-mt76.
>>>
>>> Doesn't this indicate another issue somewhere, since I'd assume that
>>> the buildhosts always start from a clean build directory?
>>>
>>> Joseph
>>>
>>>
>>> On 2016-03-10 17:07, John Crispin wrote:
>>>>
>>>>
>>>> On 10/03/2016 14:01, Joseph C. Lehner wrote:
>>>>> This patch has been merged in Chaos Calmer 6 days ago,
>>>>> but it also applies to trunk!
>>>>>
>>>>> Also, checking the most recent trunk images (2016-03-10),
>>>>> I've noticed that the image for the EX2700 also includes
>>>>> kmod-usb-core, kmod-usb-ohci, kmod-ledtrig-usbdev and
>>>>> kmod-usb2 (another whopping 118k), even though they
>>>>> shoudln't be, according to the PACKAGES specification.
>>>>> I encountered a similar issue while building on my machine,
>>>>> where I had to clean the whole build environment before
>>>>> a package was actually unselected.
>>>>>
>>>>> Could this be a bug in the build process somewhere?
>>>>>
>>>>> Regards
>>>>> Joseph
>>>>
>>>>
>>>>
>>>> rm -rf tmp/
>>>>
>>>> you target folder gets scanned and the result gets put into tmp/ if you
>>>> then run git pull it wont rescan target/* automagically. i would assume
>>>> that you ran into this issue
>>>>
>>>> i'll pull this into trunk aswell. i had it on my list and forgot. that
>>>> is why we ask to have 2 patches sent, 1 for trunk and one prefixed with "CC"
>>>>
>>>> 	John
>>>>
>>>>
>>>>>
>>>>> On 2016-03-01 17:04, Joseph C. Lehner wrote:
>>>>>> Remove the kmod-mt76 package from the EX2700 profile to free up
>>>>>> around 100 KiB of space on the root filesystem.
>>>>>>
>>>>>> This patch applies to both trunk and Chaos Calmer.
>>>>>>
>>>>>> Signed-off-by: Joseph C. Lehner <joseph.c.lehner at gmail.com>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> Changes in v2:
>>>>>> * Don't remove kmod-rt2800-pci
>>>>>>
>>>>>>
>>>>>> diff --git a/target/linux/ramips/mt7620/profiles/netgear.mk
>>>>>> b/target/linux/ramips/mt7620/profiles/netgear.mk
>>>>>> index d1b073a..9631537 100644
>>>>>> --- a/target/linux/ramips/mt7620/profiles/netgear.mk
>>>>>> +++ b/target/linux/ramips/mt7620/profiles/netgear.mk
>>>>>> @@ -7,7 +7,8 @@
>>>>>>
>>>>>>  define Profile/EX2700
>>>>>>  	NAME:=Netgear EX2700
>>>>>> -	PACKAGES:=-kmod-usb-core -kmod-usb2 -kmod-usb-ohci -kmod-ledtrig-usbdev
>>>>>> +	PACKAGES:=-kmod-usb-core -kmod-usb2 -kmod-usb-ohci -kmod-ledtrig-usbdev \
>>>>>> +		-kmod-mt76
>>>>>>  endef
>>>>>>
>>>>>>  define Profile/EX2700/Description
>>>>>>
>>>
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel