[OpenWrt-Devel] [PATCH netifd] add support for setting send_redirects

Daniel Golle daniel at makrotopia.org
Tue Mar 8 07:56:08 EST 2016


On Tue, Mar 08, 2016 at 01:29:36PM +0100, Daniel Golle wrote:
> It's important to note that the default value for send_redirects
> differs for interface types (it's enabled on physical ethernet
> interfaces, but disabled e.g. on VLANs), thus the default differs
> also depending on the way an on-board switch is integrated on specific
> boards. Having a way to explicitely enable or disable send_redirects is
> thus desireable also to unify the default behaviour among different,
> but seemingly similar devices supported by OpenWrt.

I forgot to mention that the different defaults for physical interfaces
vs. VLAN interfaces is due to olsrd changing the default in
/proc/sys/net/..., thus interfaces created by the kernel and not
touched by olsrd still got the original default from kernel
(send_redirects being switched on) while virtual interfaces being
created later on, eg. by network restart and such where VLANs on top
of a physical ethernet interface are being created, those will have
the new default previously set by olsrd (ie. send_redirects will be
switched off).
Due to this, the value of send_redirects after a network restart for
interfaces *not* used by olsrd suddenly differs depending on whether
they are 'physical' (e.g. eth0) interfaces or virtual interfaces
(eth0.1)...

At least allowing to explicitely configure send_redirects in netifd
seemed to be the easiest way to improve the situation significantly
without hurting anyone.
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list