[OpenWrt-Devel] [PATCH][CC] Revert "ar71xx: change some TP-link modelnames (WR841, WA701, WA730)"

[John Crispin]

On 25/04/2016 08:54, Bastian Bittorf wrote:
> * John Crispin <john at phrozen.org> [25.04.2016 07:39]:
>>> The changed image name breaks compatibility for derived projects and
>>> that's something which should only happen if there is a really good
>>> reason (e.g. security fix).
>>
>> how does it beak compatibility ?
> 
> I think they auto-download a preconfigured filename,
> which will ofcource not succeed. We circumvented this in our
> network-autoupdater in a way, that we download e.g. "$MODELNAME.bin"
> where $MODELNAME is from '/tmp/sysinfo/model' e.g. 'TP-Link TL-WDR4900 v1'
> and on the downloadserver we can "adjust" the symlinks...
> 
> I'am against reverting the commit. Lets keep it, because it makes sense.
> 
> Maybe i can give a short talk at Battlemesh v9 about proper autoupdates,
> because we have ~10 years experience in this (including 500 dead devices
> 8-)))
> 
> bye, bastian
> 


before i merged the patch i did actually look at the compat issue and
concluded that only docs will be out of date, which is not really
anything new. all issues mentioned are home made ones. specially the one
bastian mentions here. basically fixing your download script and
deploying it in this way will break forward compat as can be seen here.

we now face the decision of reverting and unbreaking out of tree issues
that can be fixed easily or avoided in future or not revert it and keep
the fix that makes the filenames more consistent. adding the "n" is
after all correct ad the antenna is not "not" detachable on the relevant
models.

	John
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel