[OpenWrt-Devel] [PATCH 3/4] ar71xx: fix giving extra arguments to Build/mktplinkfw

[Matthias Schiffer]

On 04/21/2016 11:30 AM, Rafał Miłecki wrote:
> On 21 April 2016 at 08:33, Matthias Schiffer
> <mschiffer at universe-factory.net> wrote:
>> @@ -967,8 +968,8 @@ define Device/tl-wr2543-v1
>>      BOARDNAME := TL-WR2543N
>>      DEVICE_PROFILE := TLWR2543
>>      TPLINK_HWID := 0x25430001
>> -    IMAGE/sysupgrade.bin := append-rootfs | mktplinkfw sysupgrade "-v 3.13.99"
>> -    IMAGE/factory.bin := append-rootfs | mktplinkfw factory "-v 3.13.99"
>> +    IMAGE/sysupgrade.bin := append-rootfs | mktplinkfw sysupgrade -v 3.13.99
>> +    IMAGE/factory.bin := append-rootfs | mktplinkfw factory -v 3.13.99
>>  endef
>>  TARGET_DEVICES += tl-wr2543-v1
> 
> Any idea why we don't use variables in the first place? E.g.
> VERSION := 3.13.99
> 

For the version, this would make sense, but can be done in a separate
patch. For the region code, we will eventually need to build multiple
factory images with different arguments, so in that case, using additional
arguments for the mktplinkfw build step makes sense.

Matthias

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20160421/08413dcb/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel