[OpenWrt-Devel] [PATCH] procd: restrict ujail to supported platforms

[Etienne Champetier]

cc list

2016-04-13 14:40 GMT+02:00 Etienne Champetier <champetier.etienne at gmail.com>
:

> Hi Zefir
>
> 2016-04-13 14:26 GMT+02:00 Zefir Kurtisi <zefir.kurtisi at neratec.com>:
>
>> ujail can be selected on e.g. PowerPC platforms, which
>> currently causes the procd build to fail:
>> ./trace/trace.c:48:2: error: #error tracing is not supported on this
>> architecture
>>  #error tracing is not supported on this architecture
>>   ^
>> ./trace/trace.c: In function 'tracer_cb':
>> ./trace/trace.c:128:50: error: 'reg_syscall_nr' undeclared (first use in
>> this function)
>>     int syscall = ptrace(PTRACE_PEEKUSER, c->pid, reg_syscall_nr);
>>                                                   ^
>> This patch restricts ujail to those platforms supported.
>>
>
> trace/trace.c is the source code of utrace binary,
> which is in procd-seccomp package, not procd-ujail
>
>
> http://git.openwrt.org/?p=project/procd.git;a=blob;f=CMakeLists.txt;h=74959e02951d286efda4c361eb1cbe7cba38e668;hb=HEAD#l108
>
> https://github.com/openwrt/openwrt/blob/73b5446e9a64adb1cc55da1982447251babe2076/package/system/procd/Makefile#L111
>
> https://github.com/openwrt/openwrt/blob/73b5446e9a64adb1cc55da1982447251babe2076/package/system/procd/Makefile#L132
>
>
>> Signed-off-by: Zefir Kurtisi <zefir.kurtisi at neratec.com>
>> ---
>>  package/system/procd/Makefile | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/system/procd/Makefile b/package/system/procd/Makefile
>> index 294985c..acd1714 100644
>> --- a/package/system/procd/Makefile
>> +++ b/package/system/procd/Makefile
>> @@ -49,7 +49,8 @@ endef
>>  define Package/procd-ujail
>>    SECTION:=base
>>    CATEGORY:=Base system
>> -  DEPENDS:=@KERNEL_NAMESPACES + at KERNEL_UTS_NS + at KERNEL_IPC_NS
>> + at KERNEL_PID_NS +libubox +libblobmsg-json
>> +  DEPENDS:=@KERNEL_NAMESPACES + at KERNEL_UTS_NS + at KERNEL_IPC_NS
>> + at KERNEL_PID_NS +libubox +libblobmsg-json \
>> +          @arm||@armeb||@mips||@mipsel||@i386||@x86_64
>>    TITLE:=OpenWrt process jail helper
>>  endef
>>
>> --
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20160413/4a9ffb05/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel