[OpenWrt-Devel] [PATCH] ar71xx: fix model string detection on NETGEAR WNDR3700/3800/WNDRMAC

Matthias Schiffer mschiffer at universe-factory.net
Wed Mar 25 12:53:31 EDT 2015


On 03/25/2015 05:46 PM, Hannu Nyman wrote:
> I tested your code with my old WNDR3700 (v1), WNDR3700v2 and WNDR3800.
> All three routers got detected ok.
> 
> My v2 is "old" and its art contents stop at byte 0x28, so it uses your
> "\xff" branch.
Ah, can you send my a dump of your ART? Then I can hopefully simplify
the patch a bit.

> 
> Just for reference, an old bug with discussion (from you?) about this
> issue:
> https://dev.openwrt.org/ticket/18992
Yes, that's from me.

> 
> 
> Ps.
> I think that you mixed the explanation regarding the old logic: The
> first W gets cut away when the ID is shorter, not when it is longer.
> 3800 would have "...+128WND..." and correct ID, but new 3700v2 would
> have "...+64WNDR..." at the same place and the detected ID would miss
> the first W.
Yes, you're right. If I send a v2 of this, I'll fix the explanation.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150325/2bd81c45/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list