[OpenWrt-Devel] [PATCH] [ar71xx] Add support for MERCURY MAC1200R

[郭传鈜]

2015-01-27 1:10 GMT+08:00 Roger Pueyo Centelles <rogerpueyo at rogerpueyo.com>:

> Hi,
>
> Thank you both for your comments.
>
> @郭传鈜:
>
> >> +       ucidef_set_led_wlan "wlan2g" "WLAN2G" "mercury:green:wlan2g"
> "phy1tpt"
> > I think the following line is incorrect:
> >> +       ucidef_set_led_wlan "wlan5g" "WLAN5G" "mercury:green:wlan5g"
> "phy0tpt"
> > There is no LED trigger called 'phy0tpt' so I think we should use netdev
> trigger like this:
> > ucidef_set_led_netdev "wlan5g" "WLAN5G" "mercury:green:wlan5g" "wlan0"
>
> Ok!
>
>
> >> +static struct gpio_keys_button mac1200r_gpio_keys[] __initdata = {
> >> +       {
> >> +               .desc           = "WPS button",
> >> +               .type           = EV_KEY,
> >> +               .code           = KEY_WPS_BUTTON,
> >> +               .debounce_interval = MAC1200R_KEYS_DEBOUNCE_INTERVAL,
> >> +               .gpio           = MAC1200R_GPIO_BTN_WPS,
> >> +               .active_low     = 1,
> >> +       },
> >> +};
> > Although the key is called WPS/RESET , I think a reset button is more
> important than a WPS button.That's just my personal opinion :)
>
> I think you are right.
>
>
> >> +       ap91_pci_init(art + MAC1200R_PCIE_CALDATA_OFFSET, tmpmac);
> > What? I think this function is only able to load CALDATA for ath9k
> devices.Maybe I'm wrong:)
>
> The router has two radios, one ath9k and one ath10k. Isn't it needed for
> the ath9k calibration data? Or this radio is already covered by
> "ath79_register_wmac(art + MAC1200R_WMAC_CALDATA_OFFSET, tmpmac); ...?
>
> Acoording to mach-archer-c7.c ,I think we should use ath79_register_pci();
here and use /lib/preinit/81_load_ath10k_board_bin to load calibration data
for ath10k.

>
> >> +$(eval $(call
> SingleProfile,TPLINK-LZMA,64kraw,MAC1200R,mc-mac1200r,MC-MAC1200R,ttyS0,115200,0x12000001,1,8Mlzma))
> >The factory image is broken since TP-LINK started to use a new firmware
> format with RSA signature in China.This should be introduced in the TOH
> wiki I think:)
>
> Done!
>
>
>
> @John:
>
> Sorry. Do you mean a description for the patch? I am not aware of what SoB
> means.
>
>
> Thanks!
>
> Roger
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150127/f42f4032/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel