[OpenWrt-Devel] [PATCH v2 7/8] sunxi: add support for Lamobo R1

[Zoltan HERPAI]

Hi Daniel,

Comments inline:

Daniel Golle wrote:
> Partially based on patchset form Wang Yi <wangyi8848 at gmail.com> published
> on https://github.com/Lamobo/Lamobo-R1-OpenWrt as well as on Bananapi DTS.
>
> Signed-off-by: Daniel Golle <daniel at makrotopia.org>
> v2: swconfig needs to be built-in, switch is not detected properly otherwise
> ---
>  .../sunxi/base-files/etc/uci-defaults/02_network   |   6 +
>  target/linux/sunxi/base-files/lib/sunxi.sh         |   4 +
>  target/linux/sunxi/config-3.18                     |   6 +
>  target/linux/sunxi/image/Makefile                  |   7 +-
>  .../patches-3.18/302-dt-sun7i-add-lamobo-r1.patch  | 252 +++++++++++++++++++++
>  target/linux/sunxi/profiles/lamobo-r1.mk           |  19 ++
>  6 files changed, 293 insertions(+), 1 deletion(-)
>  mode change 100644 => 100755 target/linux/sunxi/image/Makefile
>  create mode 100644 target/linux/sunxi/patches-3.18/302-dt-sun7i-add-lamobo-r1.patch
>  create mode 100644 target/linux/sunxi/profiles/lamobo-r1.mk
>
> diff --git a/target/linux/sunxi/base-files/etc/uci-defaults/02_network b/target/linux/sunxi/base-files/etc/uci-defaults/02_network
> index 1a9b0ed..09db8d5 100644
> --- a/target/linux/sunxi/base-files/etc/uci-defaults/02_network
> +++ b/target/linux/sunxi/base-files/etc/uci-defaults/02_network
> @@ -16,6 +16,12 @@ case "$( sunxi_board_name )" in
>  "olinuxino"*)
>  	ucidef_set_interface_lan 'wlan0'
>  	;;
> +"lamobo-r1")
> +	ucidef_set_interfaces_lan_wan "eth0.1" "eth0.2"
> +	ucidef_add_switch "switch0" "1" "1"
> +	ucidef_add_switch_vlan "switch0" "1" "4 0 1 2 8t"
> +	ucidef_add_switch_vlan "switch0" "2" "3 8t"
> +	;;
>  *)
>  	ucidef_set_interface_lan 'eth0'
>  	;;
> diff --git a/target/linux/sunxi/base-files/lib/sunxi.sh b/target/linux/sunxi/base-files/lib/sunxi.sh
> index d4dd9fe..444c7e9 100644
> --- a/target/linux/sunxi/base-files/lib/sunxi.sh
> +++ b/target/linux/sunxi/base-files/lib/sunxi.sh
> @@ -105,6 +105,10 @@ sunxi_board_detect() {
>  			board="i12-tvbox"
>  			;;
>  
> +		"Lamobo R1")
> +			board="lamobo-r1"
> +			;;
> +
>  		"Olimex A20-OLinuXino-LIME")
>  			board="olinuxino-lime"
>  			;;
>   
I'm yet to test the new layout You proposed - looks good but I'll need 
to test with the rest of the boards. I'm fine with adding the Lamobo 
board with the current layout, then move on to the new one if You're in 
a rush.

> diff --git a/target/linux/sunxi/config-3.18 b/target/linux/sunxi/config-3.18
> index 68f1593..3513f6a 100644
> --- a/target/linux/sunxi/config-3.18
> +++ b/target/linux/sunxi/config-3.18
> @@ -58,6 +58,11 @@ CONFIG_AUDIT=y
>  CONFIG_AUDIT_GENERIC=y
>  CONFIG_AUTO_ZRELADDR=y
>  CONFIG_AVERAGE=y
> +CONFIG_B53=y
> +# CONFIG_B53_MMAP_DRIVER is not set
> +CONFIG_B53_PHY_DRIVER=y
> +CONFIG_B53_PHY_FIXUP=y
> +# CONFIG_B53_SRAB_DRIVER is not set
>  CONFIG_BINFMT_MISC=y
>  CONFIG_BLK_CGROUP=y
>  CONFIG_BLK_DEV_SD=y
> @@ -427,6 +432,7 @@ CONFIG_STRICT_DEVMEM=y
>  CONFIG_SUN4I_TIMER=y
>  CONFIG_SUN5I_HSTIMER=y
>  CONFIG_SUNXI_WATCHDOG=y
> +CONFIG_SWCONFIG=y
>  CONFIG_SWIOTLB=y
>  CONFIG_SWP_EMULATE=y
>  CONFIG_SYSFS_SYSCALL=y
>   
For comment on swconfig, see below at the profile.


> diff --git a/target/linux/sunxi/image/Makefile b/target/linux/sunxi/image/Makefile
> old mode 100644
> new mode 100755
> index 4475aa8..f627ee3
> --- a/target/linux/sunxi/image/Makefile
> +++ b/target/linux/sunxi/image/Makefile
>   
[snip]
This is OK
> diff --git a/target/linux/sunxi/patches-3.18/302-dt-sun7i-add-lamobo-r1.patch b/target/linux/sunxi/patches-3.18/302-dt-sun7i-add-lamobo-r1.patch
> new file mode 100644
> index 0000000..82c8bd5
> --- /dev/null
> +++ b/target/linux/sunxi/patches-3.18/302-dt-sun7i-add-lamobo-r1.patch
>   
[snip]
Fine here as well. Do you plan to submit this DTS upstream?

> diff --git a/target/linux/sunxi/profiles/lamobo-r1.mk b/target/linux/sunxi/profiles/lamobo-r1.mk
> new file mode 100644
> index 0000000..4bc1185
> --- /dev/null
> +++ b/target/linux/sunxi/profiles/lamobo-r1.mk
> @@ -0,0 +1,19 @@
> +#
> +# Copyright (C) 2015 OpenWrt.org
> +#
> +# This is free software, licensed under the GNU General Public License v2.
> +# See /LICENSE for more information.
> +#
> +
> +define Profile/Lamobo_R1
> +	NAME:=Lamobo R1
> +	PACKAGES:=\
> +		uboot-sunxi-Lamobo_R1 kmod-ata-sunxi kmod-rtl8192cu \
> +		swconfig wpad-mini
> +endef
> +
> +define Profile/Lamobo_R1/Description
> +	Package set optimized for the Lamobo R1
> +endef
> +
> +$(eval $(call Profile,Lamobo_R1))
>   
If swconfig needs to be compiled in, I guess it can be taken out from 
the package list?

Thanks,
-w-
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel