[OpenWrt-Devel] [PATCH] brcm63xx: add Comtrend VR-3026e support

Jonas Gorski jogo at openwrt.org
Mon Aug 24 05:53:30 EDT 2015


Hi,

On Sun, Aug 23, 2015 at 5:21 PM, Martin Tesar <tesarmar at gmail.com> wrote:

A few words about the device would be nice. Please try to avoid an
empty commit message.

> Signed-off-by: Martin Tesar <tesarmar at gmail.com>

Codewise it looks good, but you used spaces for indentation; please
replace them with tabs as used everywhere else.

> ---
>  target/linux/brcm63xx/base-files/etc/diag.sh       |  3 +
>  .../base-files/etc/uci-defaults/02_network         |  3 +-
>  .../base-files/etc/uci-defaults/09_fix_crc         |  1 +
>  target/linux/brcm63xx/base-files/lib/brcm63xx.sh   |  3 +
>  .../lib/preinit/05_init_interfaces_brcm63xx        |  1 +
>  target/linux/brcm63xx/dts/vr-3026e.dts             | 84 ++++++++++++++++++++++
>  target/linux/brcm63xx/image/Makefile               |  2 +
>  .../brcm63xx/patches-4.1/805-board_VR-3026e.patch  | 81 +++++++++++++++++++++

Also currently there is still 3.18 support, so please also add the patch there.

>  target/linux/brcm63xx/profiles/comtrend.mk         |  9 +++
>  9 files changed, 186 insertions(+), 1 deletion(-)
>  create mode 100644 target/linux/brcm63xx/dts/vr-3026e.dts
>  create mode 100644 target/linux/brcm63xx/patches-4.1/805-board_VR-3026e.patch


Regards
Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list