[OpenWrt-Devel] [PATCH 1/1] [kernel] Fix kmod-v4l2 modules have missing symbols due to lack of clk support

[Hauke Mehrtens]

On 08/20/2015 01:30 AM, Daniel Dickinson wrote:
> Your patch resolves the issue of compiling - I have not yet tested the
> functionality of the resulting v4l module.  I suspect the disadvantage
> of this patch is that it will silently fail to work for the types of
> devices (DV primarily) that depend on clock support whereas my patch
> omits building code/modules for devices that depend on clock support a
> kernel config option that prevents building useless modules (although I
> realized the DV_SUPPORT should depend on CLK_COMMON since that's the
> whole reason for making that a config option) and (and of course
> #ifdef's out the code and dependencies on clk support when it's not
> present).
> 
> Regards,
> 
> Daniel

Hi Daniel,

I do not know if they will still work, but if some driver has to change
some clock of the SoC and the SoC does not support this it should fail.
The problem not only exist with ar71xx, but with all SoC in the mainline
kernel, so I assume that this is already handled. If we return the wrong
number in the ar71xx code it should be changed, different SoC code
returned different values in the same cases so I was unsure.

Have you experienced any runtime problems with the clocks with the
current trunk version?

Hauke
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel