[OpenWrt-Devel] [PATCH] Add WeIO board (http://we-io.net) profile. This patch adds support for WeIO board, which is based on Carambola2 board from 8Devices.

[Drasko DRASKOVIC]

On Mon, Jul 27, 2015 at 4:10 AM, Karl Palsson <karlp at tweak.net.au> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Just one more, I promise :)
>
> Drasko DRASKOVIC <drasko.draskovic at gmail.com> wrote:
>> +
>> +static void __init weio_common_setup(void)
>> +{
>> +     u8 *art = (u8 *) KSEG1ADDR(0x1fff0000);
>> +
>> +     ath79_register_m25p80(NULL);
>> +     ath79_register_wmac(art + WEIO_CALDATA_OFFSET,
>> +                         art + WEIO_WMAC_MAC_OFFSET);
>> +
>> +    /** WeIO uses only WiFi by default (no ETH). If ETH jack is soldered, uncomment following lines  */
>> +#if 0
>> +     ath79_setup_ar933x_phy4_switch(true, true);
>> +
>> +     ath79_init_mac(ath79_eth0_data.mac_addr, art + WEIO_MAC0_OFFSET, 0);
>> +     ath79_init_mac(ath79_eth1_data.mac_addr, art + WEIO_MAC1_OFFSET, 0);
>> +
>> +     ath79_register_mdio(0, 0x0);
>> +
>> +     /* LAN ports */
>> +     ath79_register_eth(1);
>> +
>> +     /* WAN port */
>> +     ath79_register_eth(0);
>> +#endif /** commented out ETH */
>> +}
>> +
>
>
> I still think this #ifdefed code should be removed.  None of the product
> literature on your site shows any way of this being added.  It's not
> like there is a two port ethernet footprint that's simply not mounted,
> you'd have to connect it to the breadboard headers on the side of the
> board, by the time someone's done that, it's not really the weio board
> anymore is it?

Patch re-sent with #ifdefs removed, as suggested.

I hope it is OK now.

BR,
Drasko
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel