[PATCH master,23.05] ramips: fix ZyXEL NR7101 bricking typo
Paul D
newtwen at gmail.com
Sun Oct 15 12:59:57 PDT 2023
While I second the urgency of this, I venture the question of how one
might otherwise catch these things, but for sharp eyes. There is an
attention deficit with respect to the volume of patches and PRs that
come in.
On 2023-10-15 19:41, Bjørn Mork wrote:
> A typo snuck in with the addition of Cudy M1800, changing
> "nr7101" to "nt7101". The result is a default network config
> for NR7101 without the only ethernet interface on the NR7101,
> thereby soft bricking it.
>
> Fixes: f6d394e9f2fd ("ramips: add support for Cudy M1800")
> Signed-off-by: Bjørn Mork <bjorn at mork.no>
> ---
> Ref https://forum.openwrt.org/t/zyxel-nr7101-not-responding-after-flashing-initramfs/174409
> and https://github.com/openwrt/openwrt/pull/13699
>
> This needs to be applied to 23.05 and master ASAP. It is already
> bricking devices.
>
> And it would be great if we could have some automated check
> to help us spot these kinds of unrelated and unexpected
> changes. I don't think the regular review process will ever
> be able to catch this, as that is mostly focues on the newly
> added device.
>
>
> Bjørn
>
> target/linux/ramips/mt7621/base-files/etc/board.d/02_network | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/linux/ramips/mt7621/base-files/etc/board.d/02_network b/target/linux/ramips/mt7621/base-files/etc/board.d/02_network
> index 67fe45f63360..b4c2c6dd68a8 100644
> --- a/target/linux/ramips/mt7621/base-files/etc/board.d/02_network
> +++ b/target/linux/ramips/mt7621/base-files/etc/board.d/02_network
> @@ -95,7 +95,7 @@ ramips_setup_interfaces()
> ;;
> cudy,m1800|\
> yuncore,ax820|\
> - zyxel,nt7101)
> + zyxel,nr7101)
> ucidef_set_interfaces_lan_wan "lan" "wan"
> ;;
> gnubee,gb-pc1)
More information about the openwrt-devel
mailing list