[PATCH] ath79: increase the rfkill debounce interval for TP-Link Archer C7 v2

[Paul D]

Please review/merge


On 2023-07-14 21:51, Rosen Penev wrote:
> On Fri, Jul 14, 2023 at 8:12 AM Shiji Yang <yangshiji66 at outlook.com> wrote:
>>
>> From: Shiji Yang <yangshiji66 at qq.com>
>>
>> Due to circuit issue or silicon defect, sometimes the WiFi switch button
>> of the Archer C7 v2 can be accidentally triggered multiple times in one
>> second. This will cause WiFi to be unexpectedly shut down and trigger
>> 'irq 23: nobody cared'[1] warning. Increasing the key debounce interval
>> to 1000 ms can fix this issue. This patch also add the missing rfkill
>> key label.
> Crazy. I was wondering why 2.4ghz went away. For 5ghz I understand,
> ath10k is gartbo, but 2.4ghz I didn't.
>>
>> [1] Warning Log:
>> ```
>> [87765.218511] irq 23: nobody cared (try booting with the "irqpoll" option)
>> [87765.225331] CPU: 0 PID: 317 Comm: irq/23-keys Not tainted 5.15.118 #0
>> ...
>> [87765.486246] handlers:
>> [87765.488543] [<85257547>] 0x800c29a0 threaded [<5c6328a2>] 0x80ffe0b8 [gpio_button_hotplug at 4cf73d00+0x1a00]
>> [87765.498364] Disabling IRQ #23
>> ```
>>
>> Fixes: https://github.com/openwrt/openwrt/issues/13010
>> Fixes: https://github.com/openwrt/openwrt/issues/12167
>> Fixes: https://github.com/openwrt/openwrt/issues/11191
>> Fixes: https://github.com/openwrt/openwrt/issues/7835
>>
>> Tested-by: Hans Hasert
>> Signed-off-by: Shiji Yang <yangshiji66 at qq.com>
>> ---
>>   target/linux/ath79/dts/qca9558_tplink_archer-c7-v2.dts | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/target/linux/ath79/dts/qca9558_tplink_archer-c7-v2.dts b/target/linux/ath79/dts/qca9558_tplink_archer-c7-v2.dts
>> index b7ac902003..1b860dbf2d 100644
>> --- a/target/linux/ath79/dts/qca9558_tplink_archer-c7-v2.dts
>> +++ b/target/linux/ath79/dts/qca9558_tplink_archer-c7-v2.dts
>> @@ -13,10 +13,11 @@
>>
>>   &keys {
>>          rfkill {
>> +               label = "rfkill";
>>                  gpios = <&gpio 23 GPIO_ACTIVE_LOW>;
>>                  linux,code = <KEY_RFKILL>;
>>                  linux,input-type = <EV_SW>;
>> -               debounce-interval = <60>;
>> +               debounce-interval = <1000>;
>>          };
>>   };
>>
>> --
>> 2.30.2
>>
>>
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel at lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel