[PATCH netifd 1/5] netifd: bridge: Fix format string position

Hauke Mehrtens hauke at hauke-m.de
Sun Feb 19 07:20:23 PST 2023


This fixes the following compile error:
error: format not a string literal, argument types not checked [-Werror=format-nonliteral]

blobmsg_printf() has the following signature:
int blobmsg_printf(struct blob_buf *buf, const char *name, const char *format, ...)

Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
 bridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bridge.c b/bridge.c
index 7e61b9d..ae305e8 100644
--- a/bridge.c
+++ b/bridge.c
@@ -934,7 +934,7 @@ bridge_dump_port(struct blob_buf *b, struct bridge_vlan_port *port)
 	bool tagged = !(port->flags & BRVLAN_F_UNTAGGED);
 	bool pvid = (port->flags & BRVLAN_F_PVID);
 
-	blobmsg_printf(b, "%s%s%s%s\n", port->ifname,
+	blobmsg_printf(b, NULL, "%s%s%s%s\n", port->ifname,
 		tagged || pvid ? ":" : "",
 		tagged ? "t" : "",
 		pvid ? "*" : "");
-- 
2.39.1




More information about the openwrt-devel mailing list