[PATCH v2] ramips: add support for Huasifei WS1208V2

[Arınç ÜNAL]

On 3.02.2023 16:03, Hauke Mehrtens wrote:
> On 1/27/23 14:57, arinc9.unal at gmail.com wrote:
>> From: Arınç ÜNAL <arinc.unal at arinc9.com>
>>
>> The Huasifei WS1208V2 is an AC1200 router featuring 5 Ethernet ports 
>> with a
>> Quectel RM520N-GL cellular modem which supports QMI and MBIM modes.
>>
>> Specifications:
>> - MT7621AT, 256 MiB RAM, 16 MiB SPI Flash
>> - MT7603EN 2.4 GHz & MT7612EN 5 GHz WLAN
>> - Quectel RM520N-GL Cellular Modem
>> - 2 WLAN & 4 Cellular Antennas
>> - 5 Gigabit Ethernet Ports
>> - 1 USB 2.0 port
>> - 1 PCI-E Slot
>> - 1 M.2 slot
>> - 1 SIM card slot
>> - 1 SD card slot
>>
>> Installation:
>> - Install sysupgrade image via ROOter OS.
>>
>> TFTP Recovery:
>> - Connect to serial console.
>> - Boot initramfs image by choosing option 1 when U-Boot prompts.
>> - Install sysupgrade image via OpenWrt.
>>
>> Link: https://www.huasifei.com/a/Products/5G%20CPE/240.html
>> Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>
>> ---
>>
>> v2: Add recovery information.
>>
>> ---
>>   .../ramips/dts/mt7621_huasifei_ws1208v2.dts   | 187 ++++++++++++++++++
>>   target/linux/ramips/image/mt7621.mk           |  12 ++
>>   .../mt7621/base-files/etc/board.d/01_leds     |   3 +
>>   3 files changed, 202 insertions(+)
>>   create mode 100644 target/linux/ramips/dts/mt7621_huasifei_ws1208v2.dts
>>
>> diff --git a/target/linux/ramips/dts/mt7621_huasifei_ws1208v2.dts 
>> b/target/linux/ramips/dts/mt7621_huasifei_ws1208v2.dts
>> new file mode 100644
>> index 0000000000..c69f05a0f4
>> --- /dev/null
>> +++ b/target/linux/ramips/dts/mt7621_huasifei_ws1208v2.dts
>> @@ -0,0 +1,187 @@
> .....
>> +&factory {
>> +    compatible = "nvmem-cells";
>> +    #address-cells = <1>;
>> +    #size-cells = <1>;
>> +
>> +    macaddr_factory_e000: macaddr at e000 {
>> +        reg = <0xe000 0x6>;
>> +    };
>> +};
> 
> Please move this directly where you defined the factory partition in the 
> partitions node.

Will do.

> 
>> diff --git a/target/linux/ramips/image/mt7621.mk 
>> b/target/linux/ramips/image/mt7621.mk
>> index 2269833e48..bbd25e5be0 100644
>> --- a/target/linux/ramips/image/mt7621.mk
>> +++ b/target/linux/ramips/image/mt7621.mk
>> @@ -996,6 +996,18 @@ define Device/humax_e10
>>   endef
>>   TARGET_DEVICES += humax_e10
>> +define Device/huasifei_ws1208v2
>> +  $(Device/dsa-migration)
>> +  $(Device/uimage-lzma-loader)
>> +  IMAGE_SIZE := 16064k
>> +  DEVICE_VENDOR := Huasifei
>> +  DEVICE_MODEL := WS1208V2
>> +  DEVICE_PACKAGES := kmod-ata-ahci kmod-mt7603 kmod-mt76x2 
>> kmod-sdhci-mt7620 \
>> +    kmod-usb3 kmod-usb-net-cdc-mbim kmod-usb-net-qmi-wwan \
>> +    kmod-usb-serial-option -wpad-basic-wolfssl
> 
> Why do you remove wpad-basic-wolfssl?

This shouldn't be there, thanks for pointing it out.

> What is kmod-usb-net-cdc-mbim needed for?

That's to manage the cellular modem using the MBIM specification. 
ModemManager or umbim can be used for this. Speaking of umbim, it would 
be great if you could apply these fixes on umbim.

https://github.com/openwrt/openwrt/pull/4405

Arınç