[rpcd PATCH 3/4] rc: add option to skip running check for list method

[Karl Palsson]

Christian Marangi <ansuelsmth at gmail.com> wrote:
> On Wed, Feb 01, 2023 at 10:50:24AM -0000, Karl Palsson wrote:
> > 
> > 
> > 
> > Christian Marangi <ansuelsmth at gmail.com> wrote:
> > > Running check may be slow and increase result time in the other
> > > of 70ms for the list method.
> > > 
> > > Add an option to skip running check by passing the
> > > skip_running_check as true in the list method args to speedup
> > > execution if the running info is not needed.
> > > 
> > > With the option set to true the execution time lower to just
> > > 5ms.
> > 
> > Can I ask what you're doing that you are calling ubus service
> > list so often that 70ms vs 5ms is meaningful? You're complicating
> > APIs and adding code for what seems wildly unnecessary?
> > 
> 
> I may have messed up the times...
> 
> But just compare yourselt...
> 
> time ubus call rc list
> 
> time ubus call luci getInitList
> 
> The difference is quite drammatic...
> 
> This series just allign the rc feature to the luci one and it's
> really not bloating, just adding feature... The added option
> are all optional.

Well, it certainly sounds like bloat when there's two services
doing the same thing :) Surely one of these needs to be removed?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP-digital-signature.html
Type: application/pgp-signature
Size: 1175 bytes
Desc: OpenPGP Digital Signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20230201/438564be/attachment.sig>