[PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"

[Elliott Mitchell]

On Thu, Dec 14, 2023 at 10:38:34AM +0100, Jonas Gorski wrote:
> On Wed, 13 Dec 2023 at 23:55, Elliott Mitchell <ehem+openwrt at m5p.com> wrote:
> >
> > If my belief no one is using CONFIG_PINCTRL on a Geode platform is
> > correct, then the original patch is correct.  From examination of the
> > Linux kernel source, I believe none of Geode's normal peripherals go
> > through the PINCTRL subsystem.
> >
> > Problem is too few people have systems with Geode processors in use, so
> > support is difficult.
> 
> Here, I'll do some research work for you:
> 
> 1. To select the MCP23S08 driver you need to have PINCTRL enabled
> since 4.13 (see also [1]).
> 2. At time of Linux 4.14, PINCTRL was a non user-selectable symbol [2].
> 3. Therefore, a driver selecting this was needed in the kernel config
> (it didn't matter which one).

I didn't specifically check these, but I was operating on believing the
situation was roughly this.

> 4. In a later Linux release (4.15), PINCTRL was changed to a
> user-selectable symbol [3].

Kconfig isn't my enemy, but nor is it my friend.  I can believe that was
sufficient to have that effect.  I was unaware it had actually changed
since that delta is rather small to cause such a change.

> 5. Therefore, the intel driver is not needed anymore, but PINCTRL
> needs to stay enabled.
> 
> And since we build the MCP23S08 driver as a module/kmod package, it
> really doesn't matter if this driver is used or not; having it
> available makes sure it can be installed if needed.

I remain doubtful of anyone having used CONFIG_PINCTRL on a Geode system,
but I was never planning to do anything beyond reverting 4eda2fddf2.
Notice how the patch does nothing more or less than reverting 4eda2fddf2?

I have noticed rather a lot of Intel-only features sneaking into
OpenWRT's kernels.  As someone who relies on ECC for reliability, Intel
is presently unacceptable so those are bloat to me.

There was a problem of 4eda2fddf2 looking quite strange since it chose to
enable an option ill-suited to the hardware.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445