[PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"

[Martin Schiller]

On 2023-12-13 02:45, Elliott Mitchell wrote:
> On Tue, Dec 12, 2023 at 04:54:05PM +0100, Jonas Gorski wrote:
>> 
>> On Sun, 10 Dec 2023 at 18:51, Elliott Mitchell <ehem+openwrt at m5p.com> 
>> wrote:
>> >
>> > Date: Fri, 3 Nov 2023 22:57:43 -0700
>> >
>> > Enabling an Intel chipset feature on a platform originally made by
>> > National Semiconductor and later bought by AMD.  Could we cut the Intel
>> > enthusiasm?
>> >
>> > This reverts commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f.
>> 
>> commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f says "This makes it
>> possible to use the MCP23S08 i/o expander on geode platforms with
>> linux 4.14."
> 
> Problem is this is nonsensical.  A Geode processor CANNOT be paired 
> with
> an Intel chipset (the original Geode GX1 came out of National
> Semiconductor/Cyrix and was later bought by AMD).
> 
>> So we don't need to enable PINCTRL (via other symbols) anymore for 
>> this?
> 
> No idea, I wasn't able to find very much information when I looked at
> this.
> 
> I did find:
> https://lists.openwrt.org/pipermail/openwrt-devel/2018-August/019479.html
> 
> This doesn't tell me what platform Martin Schiller was trying for.
> 17f30bfcf7 makes me suspect Martin Schiller was simply trying to do 
> this
> to all x86 platforms and didn't realize geode was a specialized target.
> 
> Alternatively Martin Schiller may have been trying to use a MCP23S08 on 
> a
> Geode processor.  Unfortunately using CONFIG_X86_INTEL_LPSS is a 
> bizzare
> choice since CONFIG_X86_AMD_PLATFORM_DEVICE has fewer side-effects and
> then current Geodes were AMD processors.
> 
> With sparse information the former is my present belief.  Is anyone
> reading this list using a Geode processor with a MCP23S08?  Otherwise 
> my
> present belief is only people with Intel x86 processors are interested 
> in
> the MCP23S08.

Hi.

The problem was and is that the PINCTRL subsystem can only be used on 
x86
platforms if either X86_INTEL_LPSS or X86_AMD_PLATFORM_DEVICE is 
activated.
I no longer know why I chose the former at the time.

X86_AMD_PLATFORM_DEVICE is now activated for x86/generic and x86/64.

 From my point of view, we can deactivate X86_INTEL_LPSS if no one else
need it.

Regards,
Martin