[PATCH 0/5] Scripting tweaks
Elliott Mitchell
ehem+openwrt at m5p.com
Mon Dec 4 19:20:57 PST 2023
Due to needing to figure out how the build process functions, I ended up
looking at scripts/kconfig.pl. Part of figuring out any program is
looking at them and figuring out their operation.
My understanding is still incomplete, but I do know more about the
function. I can state `kconfig.pl` takes arguments in a form similar to
`expr`, but uses operator prefix notation. I decided I didn't need to
dig further.
I'm glad I spotted the situation with parse_expr() during my review, I
almost sent a version with a bug.
The file is presently marked as GPLv2. I propose moving to GPLv2 or
later, which is easy right now with only 2 authors.
Then when looking at this, the situation with include/shell.sh jumped
out. Seems like a good removal. I've attempted to test, but I fear I
may not have quite confirmed I got the removal right.
I fear the e-mail situation is still unresolved. Alas, this is what
spam has done to e-mail. It used to be rather faster and more reliable
than letters, yet now.
Elliott Mitchell (5):
scripts/kconfig.pl: fixup subroutine style
scripts/kconfig.pl: modify config_and()/config_sub() to match other
ops
scripts/kconfig.pl: switch to using function references/hash for
operators
scripts/kconfig.pl: consistently call parse_expr() with 2 args
build: remove shell.sh
include/shell.sh | 15 -------
include/unpack.mk | 4 +-
package/kernel/mac80211/Makefile | 2 +-
rules.mk | 1 -
scripts/kconfig.pl | 76 ++++++++++++--------------------
5 files changed, 30 insertions(+), 68 deletions(-)
delete mode 100644 include/shell.sh
--
(\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/)
\BS ( | ehem+openwrt at m5p.com PGP 87145445 | ) /
\_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
More information about the openwrt-devel
mailing list