Add SoB tag to hack patches on generic target
Bjørn Mork
bjorn at mork.no
Tue Sep 20 04:48:32 PDT 2022
Ansuel Smith <ansuelsmth at gmail.com> writes:
> Some user [1] are trying to improve the situation and checked
> all the changes done to a specific patch and added the related
> SoB tag.
>
> I have some concern about adding arbitrary SoB tag without
> clear permission of the developer.
Definitely. Anyone can add their own SoB, but no one can add anyone
else's.
However, the way I read the DCO, it is possible to add a commit message
with your own SoB based on option (b) without a SoB from the original
author. The original Author should be preserved in the From header of
the patch (or as the first line of the body if submitted by email by
someone else).
For reference, this is the DCO from the kernel
Documentation/process/submitting-patches.rst :
---
Developer's Certificate of Origin 1.1
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
then you just add a line saying::
Signed-off-by: Random J Developer <random at developer.example.org>
using your real name (sorry, no pseudonyms or anonymous contributions.)
This will be done for you automatically if you use ``git commit -s``.
---
I believe it is pretty clear that you cannot certify any of that on
behalf of another person.
Bjørn
More information about the openwrt-devel
mailing list