[PATCH] usteer: Fix better candidate not being set in policy

Wojciech Dubowik Wojciech.Dubowik at westermo.com
Tue May 17 05:12:41 PDT 2022


The candidate is never set in this loop. Fix it by setting it
to the first valid entry.

Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik at westermo.com>
---
 policy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/policy.c b/policy.c
index a7efc06..8155e24 100644
--- a/policy.c
+++ b/policy.c
@@ -143,7 +143,7 @@ find_better_candidate(struct sta_info *si_ref, struct uevent *ev, uint32_t requi
 			ev->select_reasons = reasons;
 		}
 
-		if (candidate && si->signal > candidate->signal)
+		if (!candidate || si->signal > candidate->signal)
 			candidate = si;
 	}
 
-- 
2.25.1




More information about the openwrt-devel mailing list