[PATCH 3/4] hostapd: introduce mbo option

[Andre Valentin]

Hello Stijn!

Am 21.06.22 um 15:36 schrieb Stijn Tintel:
> Introduce a new option mbo to toggle Multi Band Operation aka Agile
> Multiband for a BSS. As the specification requires APs to support OTA
> when FT is supported, force OTA on when FT is enabled.
> 
> Signed-off-by: Stijn Tintel <stijn at linux-ipv6.be>
> ---
>   package/network/services/hostapd/files/hostapd.sh | 13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/package/network/services/hostapd/files/hostapd.sh b/package/network/services/hostapd/files/hostapd.sh
> index fa344bd2dd..59b3128669 100644
> --- a/package/network/services/hostapd/files/hostapd.sh
> +++ b/package/network/services/hostapd/files/hostapd.sh
> @@ -304,7 +304,7 @@ hostapd_common_add_bss_config() {
>   	config_add_string wps_device_type wps_device_name wps_manufacturer wps_pin
>   	config_add_string multi_ap_backhaul_ssid multi_ap_backhaul_key
>   
> -	config_add_boolean wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition
> +	config_add_boolean wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition mbo
>   	config_add_int time_advertisement
>   	config_add_string time_zone
>   	config_add_string vendor_elements
> @@ -825,11 +825,17 @@ hostapd_set_bss_options() {
>   		append bss_conf "iapp_interface=$ifname" "$N"
>   	}
>   
> -	json_get_vars time_advertisement time_zone wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition
> +	json_get_vars time_advertisement time_zone wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition mbo
>   	set_default bss_transition 0
>   	set_default wnm_sleep_mode 0
>   	set_default wnm_sleep_mode_no_keys 0
>   
> +	if [ "$enable_ax" -eq 1 ]; then
> +		set_default mbo 1
> +	else
> +		set_default mbo 0
> +	fi
> +
>   	[ -n "$time_advertisement" ] && append bss_conf "time_advertisement=$time_advertisement" "$N"
>   	[ -n "$time_zone" ] && append bss_conf "time_zone=$time_zone" "$N"
>   	if [ "$wnm_sleep_mode" -eq "1" ]; then
> @@ -837,6 +843,7 @@ hostapd_set_bss_options() {
>   		[ "$wnm_sleep_mode_no_keys" -eq "1" ] && append bss_conf "wnm_sleep_mode_no_keys=1" "$N"
>   	fi
>   	[ "$bss_transition" -eq "1" ] && append bss_conf "bss_transition=1" "$N"
> +	[ "$mbo" -eq 1 ] && append bss_conf "mbo=1" "$N"
>   
>   	json_get_vars ieee80211k rrm_neighbor_report rrm_beacon_report
>   	set_default ieee80211k 0
> @@ -883,6 +890,8 @@ hostapd_set_bss_options() {
>   				;;
>   			esac
>   
> +			[ "$mbo" -eq 1 ] && ft_over_ds=1
> +
I'm a bit irritated about that. Why does mbo force this. To my knowledge, ft_over_ds=1 forces the roaming to go over the backhaul, not directly to the new AP.
So if the client can't reach his old AP, he won't roam.
Is that really correct?

>   			[ -n "$network_ifname" ] && append bss_conf "ft_iface=$network_ifname" "$N"
>   			append bss_conf "mobility_domain=$mobility_domain" "$N"
>   			append bss_conf "ft_psk_generate_local=$ft_psk_generate_local" "$N"

Kind regards,

André
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20220621/66252b7e/attachment.sig>