[PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Rui Salvaterra
> Sent: Samstag, 25. September 2021 20:32
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: openwrt-devel at lists.openwrt.org; rosenp at gmail.com
> Subject: Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove
> holes
> 
> Hi, Adrian,
> 
> On Fri, 24 Sept 2021 at 22:28, Adrian Schmutzler <mail at adrianschmutzler.de>
> wrote:
> >
> > Commit title prefix should be "ath79: ag71xx:" or just "ath79:".
> 
> To be honest, it makes more sense to me to have "
> 
> ath79/ag71xx:", as it conveys the same information requiring one character
> less (and this format has often been used before). However, "ath79:" works
> for me too. Shall I respin?

Well, rule is that prefix has to be the target. I don't see why we should deviate from this rule now just to save a character.

Best

Adrian

> 
> 
> > Apart from that, I can contribute nothing useful :-(
> 
> Thanks,
> Rui
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210925/f6ebf2a8/attachment.sig>