[PATCH] realtek-poe: add support for PoE on Realtek switches

[Paul Fertser]

Hello John,

Thank you for the rather useful tool. One comment below.

On Tue, May 11, 2021 at 05:22:43PM +0200, John Crispin wrote:
> +/* 0x17 - Set power management mode
> + *	0: None (No Power Management mode) (Default in Semi-Auto mode)
> + *	1: Static Power Management with Port Priority(Default in Automode)
> + *	2: Dynamic Power Management with Port Priority
> + *	3: Static Power Management without Port Priority
> + *	4: Dynamic Power Management without Port Priority
> + */
> +static int
> +poe_cmd_power_mgmt_mode(unsigned char mode)
> +{
> +	unsigned char cmd[] = { 0x18, 0x00, mode };

Typo in command number here.

Because of it on D-Link DGS-1210-10P R1 with

        "firmware": "v24.33",
        "mcu": "Nuvoton M05xx LAN Microcontroller",

the power is never provided, the port status changes between "unknown"
(6):
RX -> 0x2a 0x63 0x00 0x11 0xb6 0x11 0x11 0x11 0x11 0x11 0x11 0xba
and "Searching" (1) when I plug and unplug the cable.

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav at gmail.com