Suggestion: Explicitly warn to not use GitHub web UI for patches

[Adrian Schmutzler]

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Paul D
> Sent: Dienstag, 5. Oktober 2021 16:24
> To: openwrt-devel at lists.openwrt.org
> Subject: Re: Suggestion: Explicitly warn to not use GitHub web UI for
patches
> 
> Roughly
> 
> Write this up into an FAQ/howto on openwrt.org (this is, after all, the
OWRT
> way)
> 
> Link to it in a
> 
> https://docs.github.com/en/repositories/configuring-branches-and-merges-
> in-your-repository/defining-the-mergeability-of-pull-
> requests/troubleshooting-required-status-checks
> 
> which looks for any commit containing:
> 
> 
> Committer: "GitHub <noreply at github.com>"
> 
> 
> 
> Accepting "drive-by" PRs is overall a good thing, even if it is a bumpy
path.

Is it still when getting it done means not accepting three other PRs,
because all time is consumed for hacking git vs. GitHub UI?

Best

Adrian

> 
> 
> 
> 
> On 2021-10-03 23:22, Adrian Schmutzler wrote:
> > Hi,
> >
> > I've repeatedly made the observation that people who submit PRs with
> edits
> > from GitHub's web interface cannot do history edits there when we
> request
> > them.
> >
> > This leads to a lot of frustration both for the reviewers and the
> > submitters. Eventually, it's mostly one of the following three
undesirable
> > options:
> >
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel