[PATCH v3] realtek: ensure output drivers are enabled in RTL8231

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Paul Fertser
> Sent: Samstag, 2. Oktober 2021 18:51
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: openwrt-devel at lists.openwrt.org; 'Sander Vanheule'
> <sander at svanheule.net>
> Subject: Re: [PATCH v3] realtek: ensure output drivers are enabled in
> RTL8231
> 
> Hello Adrian,
> 
> Thank you for taking care about this. One note below.
> 
> On Sat, Oct 02, 2021 at 06:37:22PM +0200, Adrian Schmutzler wrote:
> > > The bootloader can leave the GPIO expander in a state which doesn't
> > > have output drivers enabled so GPIOs will properly work for input
> > > but output operations will have no effect.
> ...
> > > Reviewed-by: Sander Vanheule <sander at svanheule.net>
> > > Signed-off-by: Paul Fertser <fercerpav at gmail.com>
> >
> > I added
> >
> > Fixes: 16ae56b4f9ec ("realtek: fix RTL8231 gpio expander for high
> > GPIOs")
> 
> Even though the patch changes the code that was introduced before with
> the patch you mention it's not fixing it. Commit 16ae56b4f9ec was fixing
> another bug (working with high GPIOs) and it was consistent with the
> existing code (that wasn't changing input/output state on init). However,
> that clearly leads to GPIOs not being able to work for output at least on
some
> of the supported targets so if anything it should have
> 
> Fixes: 2b88563ee5aa ("realtek: update the tree to the latest refactored
> version")

Thanks for the explanation.

In this case, I will simply drop my Fixes: again and use the patch as you
provided it.

Best

Adrian

> 
> --
> Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
> mailto:fercerpav at gmail.com
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel