[PATCH 2/2] ramips: mt7621: Add support for ZyXEL LTE3301-Plus

[Bjørn Mork]

Andre Valentin <avalentin at marcant.net> writes:

>>> diff --git a/target/linux/ramips/mt7621/base-
>>> files/etc/board.d/03_gpio_switches b/target/linux/ramips/mt7621/base-
>>> files/etc/board.d/03_gpio_switches
>>> index ed728b07c4..1959d8c9d2 100644
>>> --- a/target/linux/ramips/mt7621/base-files/etc/board.d/03_gpio_switches
>>> +++ b/target/linux/ramips/mt7621/base-files/etc/board.d/03_gpio_switches
>>> @@ -22,6 +22,9 @@ ubnt,edgerouter-x-sfp)
>>>  	ucidef_add_gpio_switch "poe_power_port3" "PoE Power Port3"
>>> "403"
>>>  	ucidef_add_gpio_switch "poe_power_port4" "PoE Power Port4"
>>> "404"
>>>  	;;
>>> +zyxel,lte3301-plus)
>>> +	ucidef_add_gpio_switch "lte_power" "Power LTE modem" "507"
>>> +	;;
>> 
>> Is this redundant with the lte_power hog? If yes, please decide for one of the two settings.
> I've got some questions here.
> Personnally I use a special scripts for this modem, taking use of the lte_power line.
> I.E., reset the modem if it does not work anymore.
>
> So I do not want to set the GPIO alway to on. It should default to on, but be changable from userspace.
> What would be the correct implementation?

Does the LTE3301-PLUS only have this single GPIO for hard reset of the
modem?  If so, then I fully agree - it should be a userspace switch.
Drop the hog then.

The NR7101 had no less than 3 GPIOs controlling power and reset to the
modem, named "lte_pwrkey", "lte_power" and "lte_reset" in the gpio
config file I found in the jffs2 filesystem hidden in the flash hole.  I
didn't know what to make out of that, but saw no reason to leave all 3
for userspace.  So I make "lte_reset" a userspace switch and the other 2
gpio-hogs.  Somewhat arbitrary choice.



Bjørn