[PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

Hauke Mehrtens hauke at hauke-m.de
Sat Mar 20 19:58:26 GMT 2021


On 3/20/21 2:05 PM, Jo-Philipp Wich wrote:
> Hi Hauke,
> 
> thanks for looking into it!
> 
> I have a couple of remarks...
> 
>> [...]
>>   [ "$(uci -q get uhttpd.main.ubus_socket)" = "/var/run/ubus.sock" ] && {
>>   	uci set uhttpd.main.ubus_socket='/var/run/ubus/ubus.sock'
>>   	uci commit uhttpd
>> +	reload_config
> 
> That might reload other, unrelated changes. It likely isn't that much of
> a problem in practise for most users but could interfere with other
> provisioning setups or custom logic.
> 
> I think it is better if we simply perform a selective /etc/init.d/uhttpd
> reload call here.

thanks for the hint, I updated the code.

Hauke



More information about the openwrt-devel mailing list