[PATCH 3/3] ath79: add support for MikroTik RouterBOARD 912UAG-2HPnD

[Koen Vandeputte]

On 14.06.21 20:02, Adrian Schmutzler wrote:
> Hi,
>
> a few remaining comments below.
>
>> +	gpio-export {
>> +		compatible = "gpio-export";
>> +
>> +		usb_power {
>> +			label = "power:usb";
> gpio-export nodes normally don't have a label property. We have gpio-export,name instead.
OK. Thanks
>
>> +			gpio-export,name = "power-usb";
>> +			gpio-export,output = <1>;
>> +			gpios = <&ssr 6 GPIO_ACTIVE_HIGH>;
>> +		};
>> +
>> +		pcie_power {
>> +			label = "power:pcie";
>> +			gpio-export,name = "power-pcie";
>> +			gpio-export,output = <0>;
>> +			gpios = <&ssr 7 GPIO_ACTIVE_HIGH>;
>> +		};
>> +	};
>> +};
>> +
>> +&spi {
>> +	status = "okay";
>> +
>> +	compatible = "qca,ar7100-spi";
>> +
>> +	cs-gpios = <0>, <&gpio_latch 0 GPIO_ACTIVE_LOW>;
> I still don't think this belongs here. Why would it be the only device requiring this, while we removed it everywhere else?
>
>> +
>> +	flash at 0 {
>> +		compatible = "jedec,spi-nor";
>> +		reg = <0>;
>> +		spi-max-frequency = <80000000>;
> Typically, speeds > 50 MHz require m25p,fast-read?
I checked datasheets for all revisions (carrying different NOR's) and 
80MHz was the lowest common for all.
This was also tested on all various boards.

But I do agree to play safe here and reduce to 50.
The performance impact is nearly 0 while avoiding issues on potential 
newer revisions later on.

Thanks for the insights.

>
> Best
>
> Adrian


@ Denis
I can adapt this right away in my staging tree if that's ok with you.