[PATCH] dnsmasq: Ignore carrier status for bridge interfaces

[Reuben Dowle]

I agree that there does seem to be a bug in netifd here.

That said, it also does not make sense to look at the carrier status of some types of interface that don't have this information. A bridge interface can never have carrier down status. The interface itself can be up or down, but not the carrier. 

-----Original Message-----
From: Petr Štetiar <ynezz at true.cz> 
Sent: Wednesday, 23 December 2020 12:27 am
To: Reuben Dowle <reuben.dowle at 4rf.com>
Cc: openwrt-devel at lists.openwrt.org
Subject: Re: [PATCH] dnsmasq: Ignore carrier status for bridge interfaces

Reuben Dowle <reuben.dowle at 4rf.com> [2020-07-16 00:10:43]:

Hi,

> This occurs because netifd can incorrectly indicate carrier down on an 
> interface through devstatus after issuing a carrier up hotplug event.

then it seems like this should be fixed in netifd.

> This patch ignores carrier status for bridge interfaces, as this does 
> not reflect media state so is not a useful check.

This looks like a band aid, not a proper fix.

Cheers,

Petr