[PATCH 3/3] realtek: add support for ZyXEL GS1900-8HP.

Wed Jan 6 13:25:03 EST 2021

Hi Adrian,

Op woensdag 6 januari 2021 om 14:22 schreef Adrian Schmutzler 
<mail at adrianschmutzler.de>:
> Hi,
> 
> essentially the same comments as in the 2/3:
> 
>>  -----Original Message-----
>>  From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
>>  On Behalf Of Stijn Segers
>>  Sent: Mittwoch, 6. Januar 2021 01:45
>>  To: openwrt-devel at lists.openwrt.org
>>  Subject: [PATCH 3/3] realtek: add support for ZyXEL GS1900-8HP.
> 
> Remove the full stop at the end of the title.
> 
>> 
>>  The ZyXEL GS1900-8HP is an 8 port gigabit switch with PoE+ support.
>>  There are two versions on the market (v1 & v2) which share the same 
>> specs
>>  (same flash size and flash layout, same RAM size, same PoE+ power
>>  envelope) but each have a different case and board layout that they 
>> share
>>  with other GS1900 siblings. As such, adding support for the non-PoE 
>> GS1900-
>>  8 would probably be trivial.
> 
> With different board layout, it might be safer to have separate v1/v2 
> ...

I have brought this up on the Realtek thread on the forum. The same 
GS1900-8HP image
has been tested by me on a v1 and by user Kroon40 on a v2. Same amount 
of flash and
RAM. Same flash layout. In the forum thread the conclusion seemed to be 
that ZyXEL
uses a unified image for both versions (possibly even for the 
higher-port 10HP, 16,
24HP, ... versions (the HP suffixes indicating PoE support).

Link: 
https://forum.openwrt.org/t/support-for-rtl838x-based-managed-switches/57875/263

Let me know what I should do for the v3. I'll happily send in separate 
patches, but
it looks like the boards don't care. You can flash and run e.g. a 10HP 
image on an
8HP. It will work.

Thanks

Stijn

> 
>> 
>>  The v1 seems to share its PCB and case with non-PoE GS1900-8; the 
>> v2 with
>>  its already supported bigger brother, the GS1900-10HP - its board 
>> looks the
>>  same, except for two holes where the GS1900-10 has its SFP ports.
>> 
>>  Like their 10 port sibling, both devices have a dual firmware 
>> layout.
>> 
>>  Both GS1900-8HP boards have the same 70W PoE+ power budget.
>> 
>>  Specifications (v1)
>>  -------------------
>>  * SoC:       Realtek RTL8380M 500 MHz MIPS 4KEc
>>  * Flash:     Macronix MX25L12835F 16 MiB
>>  * RAM:       Nanya NT5TU128M8HE-AC 128 MiB DDR2 SDRAM
>>  * Ethernet:  8x 10/100/1000 Mbit
>>  * PoE+:      Broadcom BCM59111KMLG (IEEE 802.3at-2009 compliant, 2x)
>>  * UART:      1 serial header with populated standard pin connector 
>> on the
>>               left side of the PCB, towards the bottom. Pins are 
>> labeled:
>>               + VCC (3.3V)
>>               + TX
>>               + RX
>>               + GND
>> 
>>  Specifications (v2)
>>  -------------------
>> 
>>  * SoC:       Realtek RTL8380M 500 MHz MIPS 4KEc
>>  * Flash:     Macronix MX25L12835F 16 MiB
>>  * RAM:       Samsung K4B1G0846G 128 MiB DDR3 SDRAM
>>  * Ethernet:  8x 10/100/1000 Mbit
>>  * PoE+:      Broadcom BCM59121B0KMLG (IEEE 802.3at-2009 compliant)
>>  * UART:      1 angled serial header with populated standard pin 
>> connector
>>               accessible from outside through the ventilation slits 
>> on the
>>               side. Pins from top to bottom are clearly marked on 
>> the PCB:
>>               + VCC (3.3V)
>>               + TX
>>               + RX
>>               + GND
>> 
>>  Connection parameters for serial on both devices: 115200 8N1.
>> 
>>  Installation
>>  ------------
>> 
>>  * Configure your client with a static 192.168.1.x IP (e.g. 
>> 192.168.1.10).
>>  * Set up a TFTP server on your client and make it serve the 
>> initramfs
>>    image.
>>  * Connect serial, power up the switch, interrupt U-boot by hitting 
>> the
>>    space bar, and enable the network:
>>    # rtk network on
>>  * Since the GS1900-10HP is a dual-partition device, you want to 
>> keep the
>>    OEM firmware on the backup partition for the time being. OpenWrt 
>> can
>>    only boot off the first partition anyway (hardcoded in the DTS). 
>> To
>>    make sure we are manipulating the first partition, issue the 
>> following
>>    commands:
>>    # setsys bootpartition 0
>>    # savesys
>>  * Download the image onto the device and boot from it:
>>    # tftpboot 0x84f00000 
>> 192.168.1.10:openwrt-realtek-generic-zyxel_gs1900-
>>  8hp-initramfs-kernel.bin
>>    # bootm
>>  * Once OpenWrt has booted, scp the sysupgrade image to /tmp and 
>> flash it:
>>    # sysupgrade /tmp//tmp/openwrt-realtek-generic-zyxel_gs1900-8hp-
>>  squashfs-sysupgrade.bin
>> 
>>  Signed-off-by: Stijn Segers <foss at volatilesystems.org>
>>  ---
>>   .../realtek/base-files/etc/board.d/02_network      |  3 +++
>>   .../linux/realtek/dts/rtl8380_zyxel_gs1900-8hp.dts | 14 
>> ++++++++++++++
>>   target/linux/realtek/image/Makefile                |  9 +++++++++
>>   3 files changed, 26 insertions(+)
>>   create mode 100644 
>> target/linux/realtek/dts/rtl8380_zyxel_gs1900-8hp.dts
>> 
>>  diff --git a/target/linux/realtek/base-files/etc/board.d/02_network
>>  b/target/linux/realtek/base-files/etc/board.d/02_network
>>  index 84fefa536d..8054adc60a 100755
>>  --- a/target/linux/realtek/base-files/etc/board.d/02_network
>>  +++ b/target/linux/realtek/base-files/etc/board.d/02_network
>>  @@ -52,6 +52,9 @@ case $board in
>>   netgear,gs110tpp-v1)
>>   	ucidef_set_poe 130 "$lan_list"
>>   	;;
>>  +zyxel,gs1900-8hp)
>>  +	ucidef_set_poe 70 "$lan_list"
>>  +	;;
>>   zyxel,gs1900-10hp)
>>   	ucidef_set_poe 77 "$lan_list"
>>   	;;
>>  diff --git a/target/linux/realtek/dts/rtl8380_zyxel_gs1900-8hp.dts
>>  b/target/linux/realtek/dts/rtl8380_zyxel_gs1900-8hp.dts
>>  new file mode 100644
>>  index 0000000000..c5813227ac
>>  --- /dev/null
>>  +++ b/target/linux/realtek/dts/rtl8380_zyxel_gs1900-8hp.dts
>>  @@ -0,0 +1,14 @@
>>  +// SPDX-License-Identifier: GPL-2.0-or-later /dts-v1/;
> 
> Drop dts-v1.
> 
> Best
> 
> Adrian