[PATCH] wireguard-tools: Add dependency on kmod-wireguard

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Ilya Lipnitskiy
> Sent: Freitag, 19. Februar 2021 02:45
> To: Hannu Nyman <hannu.nyman at iki.fi>
> Cc: Jason A . Donenfeld <Jason at zx2c4.com>; openwrt-devel <openwrt-
> devel at lists.openwrt.org>; Adrian Schmutzler <mail at adrianschmutzler.de>
> Subject: Re: [PATCH] wireguard-tools: Add dependency on kmod-wireguard
> 
> Hi,
> 
> On Thu, Feb 18, 2021 at 11:11 AM Hannu Nyman <hannu.nyman at iki.fi>
> wrote:
> > There the solution was an additional virtual kernel package, which
> > could then handle the kernel mainline / oot dependency difference inside
> the target.
> > https://github.com/openwrt/openwrt/pull/3039
> Thanks for all the great feedback. How about this:
> 
> 1. Convert kmod-wireguard into a virtual package; 2. Create kmod-
> wireguard-oot (for Linux 5.4) and kmod-wireguard-it (for Linux 5.10); 3.
> Remove the virtual wireguard package (no one depends on it); 4. When Linux
> 5.4 support is removed, remove kmod-wireguard and rename kmod-
> wireguard-it to kmod-wireguard.

FYI: We once had a similar situation with sched-cake, where we named the meta-package -virtual:
https://github.com/openwrt/openwrt/commit/56db8e461546c06f9103b5965e697f2d582d4bdc

I'd personally prefer that naming scheme here as well if we stick to the meta-package approach.

Best

Adrian

> 
> That way, existing kmod-wireguard dependencies don't have to be touched
> at all.
> 
> Ilya
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210219/878f76b0/attachment.sig>