[PATCH] wireguard-tools: Add dependency on kmod-wireguard

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Ilya Lipnitskiy
> Sent: Mittwoch, 17. Februar 2021 21:25
> To: openwrt-devel at lists.openwrt.org
> Cc: Jason A . Donenfeld <Jason at zx2c4.com>; Ilya Lipnitskiy
> <ilya.lipnitskiy at gmail.com>
> Subject: [PATCH] wireguard-tools: Add dependency on kmod-wireguard
> 
> Prepares for wireguard migration to Linux 5.10. The plan is to make luci
> packages depend only on wireguard-tools, then to change the existing
> kmod-wireguard to kmod-wireguard-oot and add the in-tree module for
> 5.10. But for those changes to be made, wireguard-tools needs to depend on
> kmod-wireguard to enable luci repo changes.

I don't really get the point of this justification. Either wireguard-tools depends on kmod-wireguard, or it doesn't. In the first case, and only then, it should be "fixed" (with a proper justification describing that).
I don't understand how we need all the strategic discussion to decide this. That's probably a discussion for later on.

Best

Adrian

> 
> https://github.com/openwrt/openwrt/pull/3876#discussion_r577901541
> 
> Cc: Jason A. Donenfeld <Jason at zx2c4.com>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy at gmail.com>
> ---
>  package/network/utils/wireguard-tools/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/network/utils/wireguard-tools/Makefile
> b/package/network/utils/wireguard-tools/Makefile
> index 3cdbaa785c..3194d3d2a7 100644
> --- a/package/network/utils/wireguard-tools/Makefile
> +++ b/package/network/utils/wireguard-tools/Makefile
> @@ -36,7 +36,7 @@ define Package/wireguard-tools
>    URL:=https://www.wireguard.com
>    MAINTAINER:=Jason A. Donenfeld <Jason at zx2c4.com>
>    TITLE:=WireGuard userspace control program (wg)
> -  DEPENDS:=+ at BUSYBOX_CONFIG_IP
> + at BUSYBOX_CONFIG_FEATURE_IP_LINK
> +  DEPENDS:=+ at BUSYBOX_CONFIG_IP
> + at BUSYBOX_CONFIG_FEATURE_IP_LINK
> + +kmod-wireguard
>  endef
> 
>  define Package/wireguard-tools/description
> --
> 2.30.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20210218/4946934a/attachment.sig>