[PATCH 21.02] feeds: freifunk: use mirror from openwrt.org

Adrian Schmutzler mail at adrianschmutzler.de
Tue Feb 16 07:54:09 EST 2021


Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Petr Štetiar
> Sent: Dienstag, 16. Februar 2021 10:31
> To: openwrt-devel at lists.openwrt.org
> Cc: Petr Štetiar <ynezz at true.cz>
> Subject: [PATCH 21.02] feeds: freifunk: use mirror from openwrt.org
> 
> We shouldn't rely on GitHub for anything serious for obvious reasons.
> 
> References:
> https://github.com/openwrt/openwrt/pull/3701#issuecomment-770841946
> Signed-off-by: Petr Štetiar <ynezz at true.cz>
> ---
> 
>  We've recently got following notice from GitHub:
> 
>   "If we determine that a violation has occurred, we may need to disable the
> repository"
> 
>  BTW I find it quite weird, that we're using feed from external project and we
> don't have access there. This is for example issue now, where we wanted to
> prepare 21.02 release, but we can't even create branch in that feed
> repository, which is blocking builds[1]:
> 
>   Updating feed 'freifunk' from 'https://github.com/freifunk/openwrt-
> packages.git;openwrt-21.02' ...
>   ...
>   fatal: Remote branch openwrt-21.02 not found in upstream origin
> 
>  1. http://buildbot.openwrt.org/openwrt-
> 21.02/images/builders/imx6%2Fgeneric/builds/1/steps/updatefeeds/logs/st
> dio

In the discussion about adding this feed, there was only a very weak tendency for the addition (I added it to master then):

https://github.com/openwrt/openwrt/pull/3013

If this creates non-trivial problems/holdup or the maintainers are not interested in moving, I think making the feed optional or removing it again is the better option.

Added Sven to the recipients.

Best

Adrian

> 
>  feeds.conf.default | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/feeds.conf.default b/feeds.conf.default index
> 03bfacb620fd..7aa07a8916c1 100644
> --- a/feeds.conf.default
> +++ b/feeds.conf.default
> @@ -2,7 +2,7 @@ src-git packages
> https://git.openwrt.org/feed/packages.git
>  src-git luci https://git.openwrt.org/project/luci.git
>  src-git routing https://git.openwrt.org/feed/routing.git
>  src-git telephony https://git.openwrt.org/feed/telephony.git
> -src-git freifunk https://github.com/freifunk/openwrt-packages.git
> +src-git freifunk https://git.openwrt.org/feed/freifunk.git
>  #src-git video https://github.com/openwrt/video.git
>  #src-git targets https://github.com/openwrt/targets.git
>  #src-git management https://github.com/openwrt-
> management/packages.git
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel




More information about the openwrt-devel mailing list