[PATCH v2] fakeroot: fix to work with glibc 2.33

Ilya Lipnitskiy ilya.lipnitskiy at gmail.com
Fri Feb 12 12:52:48 EST 2021


Hi Philip,

On Thu, Feb 11, 2021 at 11:23 PM Philip Prindeville
<philipp_subx at redfish-solutions.com> wrote:
>
> Minor nit, but please combine these into a single line:
>
>
> Please indent nested #if or #ifdef's.
>
>
I can make the style changes, but a couple of points to consider:
1. These changes have already been submitted upstream[0];
2. If you look elsewhere within libfakeroot.c it is peppered with
#ifdefs that are not indented or combined, so I mostly followed the
existing code style (or the absence thereof)

Ilya

[0]: https://salsa.debian.org/clint/fakeroot/-/merge_requests/8



More information about the openwrt-devel mailing list