[RFC PATCH] ath79: remove model name from LED labels

John Crispin john at phrozen.org
Wed Sep 30 16:13:36 EDT 2020


skimmed over the thread and wondered what upstream does. a quick search 
yielded ...

-- https://www.kernel.org/doc/html/latest/leds/leds-class.html

Examples of proper LED names:

“red:disk”
“white:flash”
“red:indicator”
“phy1:green:wlan”
“phy3::wlan”
“:kbd_backlight”
“input5::kbd_backlight”
“input3::numlock”
“input3::scrolllock”
“input3::capslock”
“mmc1::status”
“white:status”

so there is not $board:: listed.

a script to drop the ^foo: from uci looks feasible. as a second step 
unifying the :function part should be a no brainer and a few greps 
showed that this look pretty consistent already.

I am certainly in favour of this.

     John




More information about the openwrt-devel mailing list