[PATCH] ath25: fix preinit Ethernet port configuration

Sergey Ryazanov ryazanov.s.a at gmail.com
Wed Sep 9 15:20:32 EDT 2020


On Wed, Sep 9, 2020 at 6:08 PM Adrian Schmutzler
<mail at adrianschmutzler.de> wrote:
> > -                             vconfig add eth0 1
> > +                             ip link add dev eth0.1 link eth0 type vlan id 1
>
> Are you sure this is correct?

Yes, I tested this command with an OpenWrt ip package :)

> I only find the following syntax:
>
> ip link add link eth0 name eth0.1 type vlan id 1
>

According to ip-link(8) a user should use 'name' argument for a new
interface, but in fact the iplink.c have the following code in the
interface creation handler:
>         /* Allow "ip link add dev" and "ip link add name" */
>        if (!name)
>                name = dev;

-- 
Sergey



More information about the openwrt-devel mailing list