[PATCH 3/3] mediatek: mt7623: use bash for generating bootable images

David Woodhouse dwmw2 at infradead.org
Tue Sep 8 04:26:34 EDT 2020


It turns out that 'echo -e' isn't portable; it doesn't work in the dash
builtin echo and Ubuntu users are complaining.

I can't even get octal (specified by POSIX) to work consistently because
those  variants of 'echo' which *do* support -e don't seem to interpret
octalwithout it.

I could switch to /bin/echo but using -e with that isn't actually
portable *either* even though it works today.

For now just stick with bash, and use its builtin. We may end up using
something else entirely; perhaps perl.

Signed-off-by: David Woodhouse <dwmw2 at infradead.org>
---
 target/linux/mediatek/image/gen_mtk_mmc_img.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/mediatek/image/gen_mtk_mmc_img.sh b/target/linux/mediatek/image/gen_mtk_mmc_img.sh
index ea8a9c63a1..2dacb9019d 100755
--- a/target/linux/mediatek/image/gen_mtk_mmc_img.sh
+++ b/target/linux/mediatek/image/gen_mtk_mmc_img.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 # Copyright © 2019 Alexey Loukianov <lx2 at lexa2.ru>
 # Copyright © 2020 David Woodhouse <dwmw2 at infradead.org>
-- 
2.26.2




More information about the openwrt-devel mailing list